PR: Add CI with github #100
Conversation
| strategy: | ||
| fail-fast: false | ||
| matrix: | ||
| PYTHON_VERSION: ['3.5', '3.6', '3.8'] |
There was a problem hiding this comment.
Seems like they've already got 3.9: probably better to know sooner! Heck I'd throw at least an pypy in there, too!
There was a problem hiding this comment.
at which point, is 3.6 even going to tell you much more than 3.5 until EOL in september?
| jobs: | ||
| linux: | ||
| name: Linux py${{ matrix.PYTHON_VERSION }} tests | ||
| runs-on: ubuntu-latest |
There was a problem hiding this comment.
baby steps, I know, but windows (and to a lesser extent, osx) is where the real problems usually occur.
There was a problem hiding this comment.
OSX build machines are "expensive" So maybe on OSX we should only run oldest and newest?
There was a problem hiding this comment.
too true, everything has a cost! i think as long as there is some coverage on all the platforms, it's solid. another thing i've done before, when the wall-clock time isn't as important as the overall resource footprint, is do strongest and weakest indicator builds by themselves (in this case, I guess that would be windows 3.5 and and linux 3.8?) and then open up the matrix, but still set a max concurrency.
| - name: Install python dependencies | ||
| run: | | ||
| pip install setuptools pip --upgrade | ||
| pip install -v -e ".[test]" |
There was a problem hiding this comment.
seems fine for now... though while running through it, I was a little surprised that the jupyter_server code paths aren't executed.
|
Thanks @bollwyvl ! It's annoying that only after merged (unless I pushed to the repo directly) I can't really know if things are working as expected, so I would rather get this merged and I can iterate on improvements on the subsequent PRs where I can see the actual changes run :-p |
Yeah, right? I've been opening up PRs against my fork's Even worse are the some of the events like |
|
Is this ready to merge? |
|
I think so @blink1073 I can iterate on this further once it is merged. |
|
Cool, thanks! |
No description provided.